Print omitted frames count for short backtrace mode by chenyukang · Pull Request #112843 · rust-lang/rust

chenyukang · 2023-06-20T14:24:32Z

Fixes #111730

rustbot · 2023-06-20T14:24:38Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-06-20T14:24:39Z

⚠️ Warning ⚠️

These commits modify submodules.

rustbot · 2023-06-20T14:24:42Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

library/std/Cargo.toml

m-ou-se

This looks okay to me. Just two suggestions:

library/std/src/sys_common/backtrace.rs

chenyukang · 2023-06-29T03:00:33Z

@rustbot ready

bors · 2023-07-03T00:42:01Z

☔ The latest upstream changes (presumably #113046) made this pull request unmergeable. Please resolve the merge conflicts.

chenyukang · 2023-07-03T01:46:59Z

@rustbot ready

bors · 2023-07-03T03:39:51Z

☔ The latest upstream changes (presumably #113176) made this pull request unmergeable. Please resolve the merge conflicts.

chenyukang · 2023-07-03T04:00:01Z

@rustbot ready

workingjubilee · 2023-07-26T04:24:05Z

Seems m-ou-se's comments were addressed!
@bors r+

bors · 2023-07-26T04:24:07Z

📌 Commit 809ef24 has been approved by workingjubilee

It is now in the queue for this repository.

…e, r=workingjubilee Print omitted frames count for short backtrace mode Fixes rust-lang#111730

chenyukang · 2023-07-30T14:20:45Z

@bors r=@workingjubilee

bors · 2023-07-30T14:20:47Z

📌 Commit 2eb2f17db146e2cbd94685c9f604b004da10a75a has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-07-30T15:47:16Z

⌛ Testing commit 2eb2f17db146e2cbd94685c9f604b004da10a75a with merge 5f486f777c84833a52a30754663621505541185f...

bors · 2023-07-30T17:13:02Z

💔 Test failed - checks-actions

workingjubilee · 2023-07-30T22:06:53Z

Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically.

@bors r+

bors · 2023-07-30T22:06:56Z

📌 Commit 7b3d1b7 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-07-30T22:31:55Z

⌛ Testing commit 7b3d1b7 with merge d4145ee...

bors · 2023-07-31T00:16:18Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing d4145ee to master...

rust-timer · 2023-07-31T01:38:49Z

Finished benchmarking commit (d4145ee): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.1%	[6.1%, 6.1%]	1
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.0%, 4.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 653.169s -> 653.113s (-0.01%)

workingjubilee · 2023-07-31T01:47:28Z

That's a really wild shift...

chenyukang · 2023-07-31T02:50:03Z

Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically.

@bors r+

Yep, the hard thing for strip backtrace message is different arch may have trivial difference, and I don't have a x64_linux in my local env :(

chenyukang · 2023-07-31T02:51:29Z

That's a really wild shift...

Interesting...
But my code changes is only related error handling, it should not be on the hot path.
we also have benchmark testing on errors?

rylev · 2023-08-05T13:15:06Z

Seems like the start of noise:

@rustbot label: perf-regression-triaged

rustbot assigned m-ou-se Jun 20, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2023

klensy reviewed Jun 20, 2023

View reviewed changes

library/std/Cargo.toml Outdated Show resolved Hide resolved

m-ou-se reviewed Jun 21, 2023

View reviewed changes

library/std/src/sys_common/backtrace.rs Outdated Show resolved Hide resolved

library/std/src/sys_common/backtrace.rs Outdated Show resolved Hide resolved

m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023

chenyukang mentioned this pull request Jun 21, 2023

Add fmt method for BacktraceFmt rust-lang/backtrace-rs#532

Merged

chenyukang force-pushed the yukang-more-on-backtrace branch 2 times, most recently from 41f4ee4 to 9378c73 Compare June 29, 2023 00:47

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2023

chenyukang force-pushed the yukang-more-on-backtrace branch from d5407b1 to 9f72cb4 Compare July 3, 2023 01:46

chenyukang force-pushed the yukang-more-on-backtrace branch from 9f72cb4 to 809ef24 Compare July 3, 2023 03:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 26, 2023

Rollup merge of rust-lang#112843 - chenyukang:yukang-more-on-backtrac…

f4a473a

…e, r=workingjubilee Print omitted frames count for short backtrace mode Fixes rust-lang#111730

matthiaskrgr mentioned this pull request Jul 26, 2023

Rollup of 5 pull requests #114084

Closed

chenyukang force-pushed the yukang-more-on-backtrace branch from 298ea5d to 2eb2f17 Compare July 30, 2023 12:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2023

normalize backtrace error messages

7b3d1b7

chenyukang force-pushed the yukang-more-on-backtrace branch from 2eb2f17 to 7b3d1b7 Compare July 30, 2023 17:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2023

bors merged commit d4145ee into rust-lang:master Jul 31, 2023

rustbot added this to the 1.73.0 milestone Jul 31, 2023

bors mentioned this pull request Jul 31, 2023

Allow ui_test style headers in compiletest #114072

Closed

rustbot added the perf-regression Performance regression. label Jul 31, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 5, 2023

Uh oh!

Conversation

chenyukang commented Jun 20, 2023

Uh oh!

rustbot commented Jun 20, 2023

Uh oh!

rustbot commented Jun 20, 2023

Uh oh!

rustbot commented Jun 20, 2023

Uh oh!

Uh oh!

m-ou-se left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

chenyukang commented Jun 29, 2023

Uh oh!

bors commented Jul 3, 2023

Uh oh!

chenyukang commented Jul 3, 2023

Uh oh!

bors commented Jul 3, 2023

Uh oh!

chenyukang commented Jul 3, 2023

Uh oh!

workingjubilee commented Jul 26, 2023

Uh oh!

bors commented Jul 26, 2023

Uh oh!

chenyukang commented Jul 30, 2023

Uh oh!

bors commented Jul 30, 2023

Uh oh!

bors commented Jul 30, 2023

Uh oh!

This comment has been minimized.

bors commented Jul 30, 2023

Uh oh!

workingjubilee commented Jul 30, 2023

Uh oh!

bors commented Jul 30, 2023

Uh oh!

bors commented Jul 30, 2023

Uh oh!

bors commented Jul 31, 2023

Uh oh!

rust-timer commented Jul 31, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

workingjubilee commented Jul 31, 2023

Uh oh!

chenyukang commented Jul 31, 2023

Uh oh!

chenyukang commented Jul 31, 2023

Uh oh!

rylev commented Aug 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants